feat(dist): re-enable ngx_devel_kit_module #11457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Re-enables `ngx_devel_kit_module`. This was originally disabled in: #10315 NDK is needed for `set_by_lua`, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates. ### Issues Resolved Fix #11455 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
fffonion
approved these changes
Aug 25, 2023
|
Should we back port it to 3.4? |
chronolaw
approved these changes
Aug 25, 2023
|
@bungle if there's a reason for not backporting this, please write it here |
team-gateway-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
### Summary Re-enables `ngx_devel_kit_module`. This was originally disabled in: #10315 NDK is needed for `set_by_lua`, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates. ### Issues Resolved Fix #11455 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com> (cherry picked from commit 442b942)
team-gateway-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
### Summary Re-enables `ngx_devel_kit_module`. This was originally disabled in: #10315 NDK is needed for `set_by_lua`, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates. ### Issues Resolved Fix #11455 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com> (cherry picked from commit 442b942)
bungle
added a commit
that referenced
this pull request
Nov 29, 2023
### Summary Re-enables `ngx_devel_kit_module`. This was originally disabled in: #10315 NDK is needed for `set_by_lua`, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates. ### Issues Resolved Fix #11455 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com> (cherry picked from commit 442b942)
bungle
added a commit
that referenced
this pull request
Nov 29, 2023
### Summary Re-enables `ngx_devel_kit_module`. This was originally disabled in: #10315 NDK is needed for `set_by_lua`, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates. ### Issues Resolved Fix #11455 Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com> (cherry picked from commit 442b942)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables
ngx_devel_kit_module.This was originally disabled in:
#10315
NDK is needed for
set_by_lua, which is the reason we re-enable it, even when Kong doesn't use it, and can only be used through Nginx configuration injections or custom Kong Nginx templates.Issues Resolved
Fix #11455
KAG-2458