Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(changelog): fix changelog entry for #11537 #11550

Merged
merged 1 commit into from
Sep 12, 2023
Merged

docs(changelog): fix changelog entry for #11537 #11550

merged 1 commit into from
Sep 12, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 12, 2023 •
edited
Loading

Summary

Fix YAML of #11537.

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw changed the title docs(changelog): fix changelog entry ofr #11537 docs(changelog): fix changelog entry for #11537 Sep 12, 2023
@chronolaw chronolaw mentioned this pull request Sep 12, 2023
Merged
3 tasks
vm-001
vm-001 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@vm-001 vm-001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please hold this PR after I remove do-not-merge label

windmgc
windmgc approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this ASAP since it blocks other PRs CI from passing the validation

@vm-001
Copy link
Contributor

vm-001 commented Sep 12, 2023

Tested, so remove the do-not-merge label.

@windmgc windmgc merged commit e6cf791 into master Sep 12, 2023
@windmgc windmgc deleted the fix/changelog_pr_11537 branch September 12, 2023 08:30
@team-gateway-bot team-gateway-bot mentioned this pull request Sep 13, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @github-actions
docs(changelog): fix changelog entry for #11537 (#11550)
f9b486a 
(cherry picked from commit e6cf791)
This was referenced Sep 13, 2023
Merged
Merged
team-gateway-bot pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @github-actions
docs(changelog): fix changelog entry for #11537 (#11550)
8a348c2 
(cherry picked from commit e6cf791)
team-gateway-bot pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @github-actions
docs(changelog): fix changelog entry for #11537 (#11550)
eacdb28 
(cherry picked from commit e6cf791)
@Kong Kong deleted a comment from team-gateway-bot Sep 13, 2023
@Kong Kong deleted a comment from team-gateway-bot Sep 13, 2023
@Kong Kong deleted a comment from team-gateway-bot Sep 13, 2023
dndx pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @dndx
docs(changelog): fix changelog entry for #11537 (#11550)
b14e625 
(cherry picked from commit e6cf791)
dndx pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @dndx
docs(changelog): fix changelog entry for #11537 (#11550)
83b7e4a 
(cherry picked from commit e6cf791)
dndx pushed a commit that referenced this pull request Sep 13, 2023
@chronolaw @dndx
docs(changelog): fix changelog entry for #11537 (#11550)
5ee6fee 
(cherry picked from commit e6cf791)
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vm-001 vm-001 vm-001 approved these changes

@windmgc windmgc windmgc approved these changes

Assignees

@chronolaw chronolaw

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @vm-001 @windmgc