Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release/3.4.x] fix(queues): shutdown flag needs to be checked while waiting #11608

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[Backport release/3.4.x] fix(queues): shutdown flag needs to be checked while waiting #11608

merged 1 commit into from
Sep 20, 2023

Conversation

team-gateway-bot
Copy link
Collaborator

@team-gateway-bot team-gateway-bot commented Sep 19, 2023 •
edited by kikito
Loading

Backport 3bf77d7 from #11456.

This fixes a flakiness issue in the tests

@kikito
Copy link
Member

kikito commented Sep 19, 2023

@hanshuebner hitting the same problem as in the backport to 3.3. Do I need to include #11376 in the backport to 3.4 ?

@kikito kikito requested a review from hanshuebner September 19, 2023 13:35
@kikito
Copy link
Member

kikito commented Sep 19, 2023

Removing approval since the flaky is still flaky.

@github-actions github-actions bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2023
kikito
kikito previously requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@kikito kikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ready yet, removing approval

@hanshuebner
fix(queues): shutdown flag needs to be checked while waiting (#11456)
f7b49c8 
The previous fix (#11376) to enable batching during shutdown failed to check
the shutdown flag while waiting for more items to batch.  If the coalescing
delay was large enough, this could cause the last batch to be lost.

(cherry picked from commit 3bf77d7)
@hanshuebner hanshuebner force-pushed the backport-11456-to-release/3.4.x branch from 97f743a to f7b49c8 Compare September 20, 2023 08:24
@hanshuebner hanshuebner dismissed kikito’s stale review September 20, 2023 08:24

Flaky test fix is now merged, this PR is rebased

@hanshuebner hanshuebner merged commit dff6860 into release/3.4.x Sep 20, 2023
@hanshuebner hanshuebner deleted the backport-11456-to-release/3.4.x branch September 20, 2023 11:11
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshuebner hanshuebner hanshuebner approved these changes

@kikito kikito kikito left review comments

Assignees

@hanshuebner hanshuebner

Labels
author/community PRs from the open-source community (not Kong Inc) size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@team-gateway-bot @kikito @hanshuebner