-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin/tcp-log):repeated sslhandshake in [tcp-log] plugin #11803
Conversation
|
hi @chenyyyang , we need a changelog(you can learn from other PRs), and if you can add test cases to cover this fix, it maybe better! |
I have already browsed the other PRs but no changelog could be found.Could you provide a template? |
|
@chenyyyang, looks good! Just add the changelog. See: https://github.com/Kong/kong/blob/master/changelog/changelog-template.yaml Add change-log here: Give it a name: |
@bungle Sure.I have added the changelog. |
@@ -0,0 +1,3 @@ | |||
message: fix an issue that repeated ssl handshake in tcp-log plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message: fix an issue that repeated ssl handshake in tcp-log plugin | |
message: **tcp-log**: fix an issue that repeated ssl handshake |
LGTM, fix as comments and we can merge this. |
Done @tzssangglass |
Co-authored-by: tzssangglass <tzssangglass@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done?
* FIX:Repeated sslhandshake in [tcp-log] plugin * add changelog * update message as the comments * Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml Co-authored-by: tzssangglass <tzssangglass@apache.org> --------- Co-authored-by: tzssangglass <tzssangglass@apache.org> (cherry picked from commit 3fed60b)
* FIX:Repeated sslhandshake in [tcp-log] plugin * add changelog * update message as the comments * Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml Co-authored-by: tzssangglass <tzssangglass@apache.org> --------- Co-authored-by: tzssangglass <tzssangglass@apache.org> (cherry picked from commit 3fed60b)
* FIX:Repeated sslhandshake in [tcp-log] plugin * add changelog * update message as the comments * Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml Co-authored-by: tzssangglass <tzssangglass@apache.org> --------- Co-authored-by: tzssangglass <tzssangglass@apache.org> (cherry picked from commit 3fed60b)
* FIX:Repeated sslhandshake in [tcp-log] plugin * add changelog * update message as the comments * Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml Co-authored-by: tzssangglass <tzssangglass@apache.org> --------- Co-authored-by: tzssangglass <tzssangglass@apache.org> (cherry picked from commit 3fed60b)
Summary
FIX: Repeated sslhandshake in [tcp-log] plugin
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdFull changelog
change the code in tcp-log/handler.lua
Issue reference
Fix #[11052]