Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin/tcp-log):repeated sslhandshake in [tcp-log] plugin #11803

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

chenyyyang
Copy link
Contributor

@chenyyyang chenyyyang commented Oct 22, 2023

Summary

FIX: Repeated sslhandshake in [tcp-log] plugin

Checklist

Full changelog

change the code in tcp-log/handler.lua

Issue reference

Fix #[11052]

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Oct 22, 2023
@tzssangglass
Copy link
Member

hi @chenyyyang , we need a changelog(you can learn from other PRs), and if you can add test cases to cover this fix, it maybe better!

@chenyyyang
Copy link
Contributor Author

I have already browsed the other PRs but no changelog could be found.Could you provide a template?

@tzssangglass
Copy link
Member

I have already browsed the other PRs but no changelog could be found.Could you provide a template?

https://github.com/Kong/kong/pull/11786/files#diff-1c9ba4aa7ac45698a290b3506fc00dc16289cd098483e8e7e2bb580d0b40a8c2

@nowNick nowNick requested a review from bungle October 23, 2023 07:14
@bungle
Copy link
Member

bungle commented Oct 23, 2023

@chenyyyang, looks good! Just add the changelog. See: https://github.com/Kong/kong/blob/master/changelog/changelog-template.yaml

Add change-log here:
https://github.com/Kong/kong/tree/master/changelog/unreleased/kong

Give it a name: fix-tcp-log-sslhandshake.yml

@chenyyyang
Copy link
Contributor Author

chenyyyang commented Oct 23, 2023

@bungle Sure.I have added the changelog.

@bungle bungle added this to the 3.5.0 milestone Oct 24, 2023
@@ -0,0 +1,3 @@
message: fix an issue that repeated ssl handshake in tcp-log plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message: fix an issue that repeated ssl handshake in tcp-log plugin
message: **tcp-log**: fix an issue that repeated ssl handshake

@tzssangglass
Copy link
Member

LGTM, fix as comments and we can merge this.

@chenyyyang
Copy link
Contributor Author

Done @tzssangglass

Co-authored-by: tzssangglass <tzssangglass@apache.org>
Copy link
Contributor Author

@chenyyyang chenyyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done?

@chronolaw chronolaw changed the title FIX:Repeated sslhandshake in [tcp-log] plugin fix(plugin/tcp-log):repeated sslhandshake in [tcp-log] plugin Oct 26, 2023
@bungle bungle merged commit 3fed60b into Kong:master Oct 26, 2023
27 checks passed
team-gateway-bot pushed a commit that referenced this pull request Oct 26, 2023
* FIX:Repeated sslhandshake in [tcp-log] plugin

* add changelog

* update message as the comments

* Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml

Co-authored-by: tzssangglass <tzssangglass@apache.org>

---------

Co-authored-by: tzssangglass <tzssangglass@apache.org>
(cherry picked from commit 3fed60b)
bungle pushed a commit that referenced this pull request Oct 26, 2023
* FIX:Repeated sslhandshake in [tcp-log] plugin

* add changelog

* update message as the comments

* Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml

Co-authored-by: tzssangglass <tzssangglass@apache.org>

---------

Co-authored-by: tzssangglass <tzssangglass@apache.org>
(cherry picked from commit 3fed60b)
team-gateway-bot pushed a commit that referenced this pull request Oct 26, 2023
* FIX:Repeated sslhandshake in [tcp-log] plugin

* add changelog

* update message as the comments

* Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml

Co-authored-by: tzssangglass <tzssangglass@apache.org>

---------

Co-authored-by: tzssangglass <tzssangglass@apache.org>
(cherry picked from commit 3fed60b)
bungle pushed a commit that referenced this pull request Oct 28, 2023
* FIX:Repeated sslhandshake in [tcp-log] plugin

* add changelog

* update message as the comments

* Update changelog/unreleased/kong/fix-tcp-log-sslhandshake.yml

Co-authored-by: tzssangglass <tzssangglass@apache.org>

---------

Co-authored-by: tzssangglass <tzssangglass@apache.org>
(cherry picked from commit 3fed60b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) plugins/tcp-log size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated sslhandshake in [tcp-log] plugin
6 participants