Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(*): fix azure plugin test due to mockbin sunset #11879

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Oct 30, 2023

Summary

This PR fixes the azure plugin test failure due to mockbin.org sunset.

Checklist

Fix

FTI-5523
KAG-2912

@chronolaw
Copy link
Contributor

It seems to be related to #11878

@AndyZhang0707
Copy link
Collaborator

@windmgc the disable PR #11878 has been merged, so please remember to update your development branch and re-enable the test.

@windmgc windmgc force-pushed the tests-azure-mockbin-replacement branch from 2292999 to 3d4deab Compare October 30, 2023 08:48
@windmgc windmgc requested a review from dndx October 30, 2023 09:00
@VicYP VicYP requested review from dndx and removed request for dndx October 31, 2023 03:22
@dndx dndx merged commit f4e54a0 into master Oct 31, 2023
24 checks passed
@dndx dndx deleted the tests-azure-mockbin-replacement branch October 31, 2023 06:30
team-gateway-bot pushed a commit that referenced this pull request Oct 31, 2023
@team-gateway-bot
Copy link
Collaborator

The backport to release/3.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-11879-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4e54a07d9459eae88ba691f1ec52b0443136c3b
# Push it to GitHub
git push --set-upstream origin backport-11879-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.x

Then, create a pull request where the base branch is release/3.4.x and the compare/head branch is backport-11879-to-release/3.4.x.

@chobits
Copy link
Contributor

chobits commented Nov 29, 2023

also backport this pr to releases/3.2.x in this PR:#12031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants