Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve backporting process #11924

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jschmid1
Copy link
Contributor

@jschmid1 jschmid1 commented Nov 6, 2023

Summary

  • now contains all the commits of a PR, not only the last one
  • now copies labels on the backport PRs
  • now copies milestones on the backport PRS
  • now copies requested reviewers to the backport PRS

The action instructions for manually merging were mostly wrong and rarely worked.
Now they are more descriptive and isolated (using worktrees)

Fix https://konghq.atlassian.net/browse/KAG-2652

@jschmid1 jschmid1 requested review from kikito and fffonion November 6, 2023 10:51
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Nov 6, 2023
@jschmid1 jschmid1 force-pushed the chore/improve-backporting-process branch from f819915 to 8d62843 Compare November 6, 2023 10:53
@jschmid1 jschmid1 requested a review from a team November 6, 2023 15:53
@jschmid1 jschmid1 force-pushed the chore/improve-backporting-process branch from 8d62843 to 9068648 Compare November 6, 2023 20:15
* now contains all the commits of a PR, not only the last one
* now copies labels on the backport PRs
* now copies milestones on the backport PRS
* now copies requested reviewers to the backport PRS

The action instructions for manually merging were mostly wrong and rarely worked.

The actions are now more descriptive and separated (using worktrees)

Signed-off-by: Joshua Schmid <jaiks@posteo.de>
@jschmid1 jschmid1 force-pushed the chore/improve-backporting-process branch from 9068648 to 2a8191e Compare November 7, 2023 11:10
@jschmid1 jschmid1 requested a review from samugi November 7, 2023 11:10
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@locao locao requested a review from zhongweiy November 7, 2023 17:48
@bungle bungle merged commit 0c1c94c into master Nov 9, 2023
@bungle bungle deleted the chore/improve-backporting-process branch November 9, 2023 04:00
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.0.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/3.0.x
git worktree add -d .worktree/backport-11924-to-release/3.0.x origin/release/3.0.x
cd .worktree/backport-11924-to-release/3.0.x
git checkout -b backport-11924-to-release/3.0.x
ancref=$(git merge-base c74cbc72963c9d6ca9916c8f47b617901d8b22de 2a8191e26346ab5137442862bb87bfbb7c3b2b09)
git cherry-pick -x $ancref..2a8191e26346ab5137442862bb87bfbb7c3b2b09

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.1.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/3.1.x
git worktree add -d .worktree/backport-11924-to-release/3.1.x origin/release/3.1.x
cd .worktree/backport-11924-to-release/3.1.x
git checkout -b backport-11924-to-release/3.1.x
ancref=$(git merge-base c74cbc72963c9d6ca9916c8f47b617901d8b22de 2a8191e26346ab5137442862bb87bfbb7c3b2b09)
git cherry-pick -x $ancref..2a8191e26346ab5137442862bb87bfbb7c3b2b09

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-11924-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-11924-to-release/3.2.x
git checkout -b backport-11924-to-release/3.2.x
ancref=$(git merge-base c74cbc72963c9d6ca9916c8f47b617901d8b22de 2a8191e26346ab5137442862bb87bfbb7c3b2b09)
git cherry-pick -x $ancref..2a8191e26346ab5137442862bb87bfbb7c3b2b09

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-11924-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-11924-to-release/3.3.x
git checkout -b backport-11924-to-release/3.3.x
ancref=$(git merge-base c74cbc72963c9d6ca9916c8f47b617901d8b22de 2a8191e26346ab5137442862bb87bfbb7c3b2b09)
git cherry-pick -x $ancref..2a8191e26346ab5137442862bb87bfbb7c3b2b09

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-11924-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-11924-to-release/3.4.x
git checkout -b backport-11924-to-release/3.4.x
ancref=$(git merge-base c74cbc72963c9d6ca9916c8f47b617901d8b22de 2a8191e26346ab5137442862bb87bfbb7c3b2b09)
git cherry-pick -x $ancref..2a8191e26346ab5137442862bb87bfbb7c3b2b09

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.5.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants