Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Backport to 3.4.x) fix(kconfig): remove kong version and edition from kconfig.js - FTI-5557 #12269

Merged
merged 2 commits into from
Jan 2, 2024
Merged

(Backport to 3.4.x) fix(kconfig): remove kong version and edition from kconfig.js - FTI-5557 #12269

merged 2 commits into from
Jan 2, 2024

Conversation

raoxiaoyan
Copy link
Contributor

@raoxiaoyan raoxiaoyan commented Dec 29, 2023 •
edited by AndyZhang0707
Loading

@raoxiaoyan raoxiaoyan changed the title Backport to 3.4.x/pr 12045 and 12097 (Backport to 3.4.x) fix(kconfig): remove kong version and edition from kconfig.js - FTI-5557 Dec 29, 2023
raoxiaoyan and others added 2 commits December 29, 2023 14:27
@raoxiaoyan
fix(kconfig): remove kong version and edition from kconfig.js
44d7644
@nekolab @raoxiaoyan
feat(admin-api): add gateway edition info to the endpoint / (#12097)
3be9fb2 
This commit is the follow-up change to the PR #12045,
since the the edition info is still useful to the kong manager, we choose to
introduce the gateway edition information in the response of the `/` endpoint.

Fix FTI-5557
@raoxiaoyan raoxiaoyan force-pushed the backport_to_3.4.x/pr_12045_and_12097 branch from ada9feb to 3be9fb2 Compare December 29, 2023 06:28
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 29, 2023
nekolab
nekolab approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyZhang0707 AndyZhang0707 merged commit a26b670 into release/3.4.x Jan 2, 2024
32 checks passed
@AndyZhang0707 AndyZhang0707 deleted the backport_to_3.4.x/pr_12045_and_12097 branch January 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

@nekolab nekolab nekolab approved these changes

Assignees

@raoxiaoyan raoxiaoyan

Labels
core/admin-api size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raoxiaoyan @nekolab @Leopoldthecoder @AndyZhang0707