tests(integration): fix flakiness #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
added
the
cherry-pick kong-ee
ADD-SP
changed the title
Some tests might change the DB in front of this test, which causes incompatible data to prevent the CP from starting up.
ADD-SP
force-pushed
the
add-sp/tests-fix-flakiness
branch
from
ef1c397
to
2f2cd07
Compare
2 tasks
StarlightIbuki
approved these changes
Feb 19, 2024
|
|
||
| describe(PLUGIN_NAME .. ": (unit)", function() | ||
| local mock | ||
| local mock_response_file = pl_path.abspath( |
There was a problem hiding this comment.
Just a note to myself: perhaps we could add a new API to use a file as the response for http_mock.
samugi
approved these changes
Feb 19, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12580-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12580-to-master-to-upstream
git checkout -b cherry-pick-12580-to-master-to-upstream
ancref=$(git merge-base 84cb1be01d8e9a241e8a2b3afd6d55bb184e605b 2f2cd079dcb0bd179b1faea27cd49ad64cd69dca)
git cherry-pick -x $ancref..2f2cd079dcb0bd179b1faea27cd49ad64cd69dca |
|
Successfully created backport PR for |
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12580-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12580-to-master-to-upstream
git checkout -b cherry-pick-12580-to-master-to-upstream
ancref=$(git merge-base 84cb1be01d8e9a241e8a2b3afd6d55bb184e605b 2f2cd079dcb0bd179b1faea27cd49ad64cd69dca)
git cherry-pick -x $ancref..2f2cd079dcb0bd179b1faea27cd49ad64cd69dca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please REBASE and MERGE
Summary
The dynamic test scheduler exposed some issues by disrupting the order of the tests, some of which did not initialize the database or wrote incompatible data to the database, causing the Gateway instance to fail to start and causing the following test to fail.
Starting a Gateway instance even if it's not needed
spec/03-plugins/39-ai-request-transformer/01-transformer_spec.luaspec/03-plugins/40-ai-response-transformer/01-transformer_spec.luaThese two test sets start a Gateway instance to launch a mocking server, which can be replaced by the
spec.helpers.http_mock.The database was not initialized before starting the Gateway instance
spec/02-integration/09-hybrid_mode/02-start_stop_spec.luaStarting a service using a fixed port instead of a random port
Since the test sequence is disrupted and the port release is not real-time, this may cause the port to be occupied to the point where the test fails.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3746