feat(AI-proxy-plugin): support the new /v1/messages API provided by Anthropic #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you have got this bang on, looks good. I think you're right that we don't need to support both old and new Claude. |
fffonion
reviewed
Mar 25, 2024
| @@ -0,0 +1,5 @@ | |||
| "message": "**AI-Proxy**: To support the new messages API of `Anthropic`, the upstream path of the `Anthropic` for `llm/v1/chat` route type is changed from `/v1/complete` to `/v1/messages`" | |||
There was a problem hiding this comment.
would this be a breaking change to mention in changelog?
There was a problem hiding this comment.
@fffonion Let me mention it in changelog, thanks!
fffonion
approved these changes
Mar 25, 2024
github-actions
bot
added
the
cherry-pick kong-ee
|
@ttyS0e Could you give this a review please? Thanks! |
3 tasks
tysoekong
force-pushed
the
ai-plugin-anthropic-messages-api
branch
from
ae09b09
to
450fcb7
Compare
|
Yes this is fantastic, if possible please merge so I can then add the "Streaming" transformation over the top for my PR. |
tysoekong
approved these changes
Mar 27, 2024
brentos
reviewed
Mar 29, 2024
kong/llm/drivers/anthropic.lua
Outdated
| if response_table.completion then | ||
| local function extract_text_from_content(content) | ||
| local buf = buffer:new() | ||
| buf:reset() |
There was a problem hiding this comment.
Do we need to reset the buffer? it was created in the previous line
brentos
reviewed
Mar 29, 2024
brentos
reviewed
Mar 29, 2024
liverpool8056
force-pushed
the
ai-plugin-anthropic-messages-api
branch
from
7e9821b
to
ef0ec90
Compare
liverpool8056
force-pushed
the
ai-plugin-anthropic-messages-api
branch
from
ef0ec90
to
90f8410
Compare
brentos
approved these changes
Apr 1, 2024
chronolaw
reviewed
Apr 8, 2024
Anthropic. In this PR, the upstream path of Anthropic for `llm/v1/chat` route type is changed, pointing to the new API path: `/v1/messages`. According to the docs of Anthropic, the `text completion` API has been deprecated. FTI-5770
…angelog/unleased/kong/
Co-authored-by: Brent Yarger <brent.yarger@konghq.com>
tysoekong
force-pushed
the
ai-plugin-anthropic-messages-api
branch
from
90f8410
to
429bfa8
Compare
|
#12792 depends on this too. I can finish off the comments here today. |
liverpool8056
force-pushed
the
ai-plugin-anthropic-messages-api
branch
from
d81f3e4
to
2d3ec5e
Compare
chronolaw
approved these changes
Apr 9, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support the newly provided API
/v1/messagesof Anthropic in AI-proxy plugin.In this PR, the upstream path of Anthropic for
llm/v1/chatroute type is changed from pointing to/v1/completeto now pointing to the new API path/v1/messages.A doc page PR is needed correspondingly for this update.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdIssue reference
FTI-5770