-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): standard-webhooks #12757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e27e52
to
3c05ed5
Compare
41ffa74
to
f2c3b59
Compare
fffonion
reviewed
Mar 25, 2024
7b14268
to
7551057
Compare
Tieske
reviewed
Mar 28, 2024
mikefero
reviewed
Apr 1, 2024
20c05e7
to
4604a96
Compare
Tieske
approved these changes
Apr 22, 2024
approved, assuming CI will go green |
341bba2
to
c4b9fb6
Compare
Done |
bdbbfb3
to
aec37f2
Compare
outsinre
reviewed
Apr 25, 2024
outsinre
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
Tieske
reviewed
Apr 25, 2024
fffonion
reviewed
Apr 25, 2024
fffonion
reviewed
Apr 25, 2024
outsinre
reviewed
Apr 26, 2024
5a1320d
to
6c66623
Compare
fffonion
reviewed
Apr 26, 2024
local MESSAGE_ID = "msg_p5jXN8AQM9LWM0D4loKWxJek" | ||
|
||
for _, strategy in helpers.all_strategies() do | ||
if strategy ~= "cassandra" then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can drop this if
, cassandra is gone now
fffonion
approved these changes
Apr 26, 2024
Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
6c66623
to
da22e80
Compare
oowl
pushed a commit
that referenced
this pull request
Jul 15, 2024
* feat(plugins): standard-webhooks (#12962) * Revert "Revert "feat(plugins): add standard-webhooks plugin (#12757)"" This reverts commit 8ff1771. * Update kong/plugins/standard-webhooks/internal.lua Co-authored-by: Samuele <samuele@konghq.com> --------- Co-authored-by: Samuele <samuele@konghq.com> (cherry picked from commit 03f056c) * fix: cherry pick * Update plugins-add-standard-webhooks.yml * Update plugins-add-standard-webhooks.yml * Update kong/plugins/standard-webhooks/handler.lua Co-authored-by: Samuele <samuele@konghq.com> * fix order --------- Co-authored-by: Samuele <samuele@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the plugin for validating payloads using the standard-webhooks specification.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.md