Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): standard-webhooks #12757

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

zekth
Copy link
Member

@zekth zekth commented Mar 19, 2024

Summary

This PR adds the plugin for validating payloads using the standard-webhooks specification.

Checklist

@github-actions github-actions bot added schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Mar 19, 2024
@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 4 times, most recently from 9e27e52 to 3c05ed5 Compare March 19, 2024 17:49
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Mar 19, 2024
@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 3 times, most recently from 41ffa74 to f2c3b59 Compare March 20, 2024 10:28
@fffonion fffonion self-requested a review March 20, 2024 11:05
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 2 times, most recently from 7b14268 to 7551057 Compare March 27, 2024 13:23
@zekth zekth requested a review from fffonion March 27, 2024 13:23
kong-3.7.0-0.rockspec Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/internal.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/schema.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/schema.lua Outdated Show resolved Hide resolved
kong/plugins/standard-webhooks/schema.lua Show resolved Hide resolved
@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 2 times, most recently from 20c05e7 to 4604a96 Compare April 22, 2024 09:27
@zekth zekth requested review from mikefero and Tieske April 22, 2024 09:27
@Tieske
Copy link
Member

Tieske commented Apr 22, 2024

approved, assuming CI will go green

@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 4 times, most recently from 341bba2 to c4b9fb6 Compare April 22, 2024 11:14
@zekth
Copy link
Member Author

zekth commented Apr 22, 2024

approved, assuming CI will go green

Done

@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 2 times, most recently from bdbbfb3 to aec37f2 Compare April 25, 2024 09:31
Copy link
Contributor

@outsinre outsinre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

@zekth zekth force-pushed the feat/standard-webhooks-plugin branch 2 times, most recently from 5a1320d to 6c66623 Compare April 26, 2024 07:41
local MESSAGE_ID = "msg_p5jXN8AQM9LWM0D4loKWxJek"

for _, strategy in helpers.all_strategies() do
if strategy ~= "cassandra" then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop this if, cassandra is gone now

Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
@zekth zekth force-pushed the feat/standard-webhooks-plugin branch from 6c66623 to da22e80 Compare April 26, 2024 08:04
@fffonion fffonion merged commit a5d3a96 into master Apr 26, 2024
25 checks passed
@fffonion fffonion deleted the feat/standard-webhooks-plugin branch April 26, 2024 08:21
@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 26, 2024
zekth added a commit that referenced this pull request Apr 29, 2024
kikito pushed a commit that referenced this pull request Apr 29, 2024
zekth added a commit that referenced this pull request Apr 29, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 30, 2024
@Kong Kong deleted a comment from team-gateway-bot Apr 30, 2024
zekth added a commit that referenced this pull request May 8, 2024
samugi added a commit that referenced this pull request May 8, 2024
* Revert "Revert "feat(plugins): add standard-webhooks plugin (#12757)""

This reverts commit 8ff1771.

* Update kong/plugins/standard-webhooks/internal.lua

Co-authored-by: Samuele <samuele@konghq.com>

---------

Co-authored-by: Samuele <samuele@konghq.com>
oowl pushed a commit that referenced this pull request Jul 15, 2024
* feat(plugins): standard-webhooks (#12962)

* Revert "Revert "feat(plugins): add standard-webhooks plugin (#12757)""

This reverts commit 8ff1771.

* Update kong/plugins/standard-webhooks/internal.lua

Co-authored-by: Samuele <samuele@konghq.com>

---------

Co-authored-by: Samuele <samuele@konghq.com>
(cherry picked from commit 03f056c)

* fix: cherry pick

* Update plugins-add-standard-webhooks.yml

* Update plugins-add-standard-webhooks.yml

* Update kong/plugins/standard-webhooks/handler.lua

Co-authored-by: Samuele <samuele@konghq.com>

* fix order

---------

Co-authored-by: Samuele <samuele@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed schema-change-noteworthy size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants