Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clustering): add compatible checkers for mixed mode routes #12814

Merged
merged 11 commits into from
Apr 23, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Mar 30, 2024

Summary

Blocked by #12667.
KAG-3806

Checklist

Issue reference

Fix #[issue number]

@chronolaw chronolaw force-pushed the feat/clustering_checkers_for_expressioins branch from 5558ac2 to c3b9afe Compare April 18, 2024 00:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 18, 2024
@chronolaw chronolaw marked this pull request as ready for review April 18, 2024 02:46
@RobSerafini RobSerafini requested review from locao and mikefero April 22, 2024 23:27
@kikito kikito merged commit f6b64ec into master Apr 23, 2024
25 checks passed
@kikito kikito deleted the feat/clustering_checkers_for_expressioins branch April 23, 2024 08:45
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12814-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12814-to-master-to-upstream
git checkout -b cherry-pick-12814-to-master-to-upstream
ancref=$(git merge-base 00d1c3ff8afddb1b9c2600701d00c7655ef9f828 21da04de0b28a8448dcf5d227b095bc15de02372)
git cherry-pick -x $ancref..21da04de0b28a8448dcf5d227b095bc15de02372

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 23, 2024
@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 23, 2024
locao pushed a commit that referenced this pull request Apr 24, 2024
* add compat checker for mixed mode routes

* unit tests

* dont send mixed routes at all

* style lint

* try test but not work

* try tests

* test fixed

* more tests

* update tests

* test descriptions

* lazy setup/teardown

try to fix tests
chronolaw added a commit that referenced this pull request Apr 30, 2024
kikito pushed a commit that referenced this pull request Apr 30, 2024
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
bungle pushed a commit that referenced this pull request Apr 30, 2024
locao pushed a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants