-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AI-Proxy): improve the robustness of anthropic's statistics #12854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent from errors when: 1. no usage provided; 2. changes in usage data;
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Apr 12, 2024
liverpool8056
added
skip-changelog
and removed
size/L
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 12, 2024
github-actions
bot
added
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
labels
Apr 12, 2024
liverpool8056
added
the
pr/ready (but hold merge)
No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
label
Apr 12, 2024
hanshuebner
suggested changes
Apr 16, 2024
hanshuebner
suggested changes
Apr 16, 2024
hanshuebner
approved these changes
Apr 16, 2024
windmgc
approved these changes
Apr 22, 2024
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
pr/ready (but hold merge)
No more concerns, but do not merge yet (probably a conflict of interest with another PR or release)
size/L
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit difference in the usage data between ai providers, and considering the variability of it, this PR attempts to improve the robustness during the process of transforming the usage data when:
In #12781 , it is arbitrarily believed that the usage data is always included and the data struct won't change. This may be a potential issue throwing an error. Therefore, this PR is a follow-up one to prevent from it.