Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AI-Proxy): improve the robustness of anthropic's statistics #12854

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

liverpool8056
Copy link
Contributor

@liverpool8056 liverpool8056 commented Apr 12, 2024

There is a bit difference in the usage data between ai providers, and considering the variability of it, this PR attempts to improve the robustness during the process of transforming the usage data when:

  1. no usage data provided in the upstream response;
  2. some possible changes in structure of usage data in the future;

In #12781 , it is arbitrarily believed that the usage data is always included and the data struct won't change. This may be a potential issue throwing an error. Therefore, this PR is a follow-up one to prevent from it.

prevent from errors when:
1. no usage provided;
2. changes in usage data;
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 12, 2024
@liverpool8056 liverpool8056 added skip-changelog and removed size/L cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 12, 2024
@liverpool8056 liverpool8056 added the pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) label Apr 12, 2024
kong/llm/drivers/anthropic.lua Outdated Show resolved Hide resolved
kong/llm/drivers/anthropic.lua Outdated Show resolved Hide resolved
@windmgc windmgc merged commit a22d696 into master Apr 22, 2024
27 checks passed
@windmgc windmgc deleted the fix/usage-ai-proxy-anthropic branch April 22, 2024 06:07
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer pr/ready (but hold merge) No more concerns, but do not merge yet (probably a conflict of interest with another PR or release) size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants