fix(plugins/AI-proxy): db migrations for AI-proxy plugin #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
3 times, most recently
from
baf22fe
to
3564074
Compare
chronolaw
changed the title
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
3 times, most recently
from
00fe371
to
35dbd50
Compare
In this PR, a database migration is added for AI-proxy plugin, disabling the log_statistics feature of this plugin for providers not supporting this feature. Also, a changelog entry is added as well to describe it.
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
from
6373428
to
0446f9f
Compare
hanshuebner
approved these changes
Apr 16, 2024
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
from
11af90c
to
c11414b
Compare
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
3 times, most recently
from
980adf9
to
37e9ee4
Compare
liverpool8056
force-pushed
the
fix/migrations-for-ai-gateway
branch
from
37e9ee4
to
1865a5c
Compare
windmgc
approved these changes
Apr 22, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up one of #12781.
In #12781 , the default value of
log_statisticsis changed fromtruetofalsefor providers not supporting this feature, and a configuration validation is added to prevent from enabling it against those unsupported providers.However, the new config validation may cause CP DP compatibility issue in case that
log_statisticshas been enabled upon those unsupported providers. Although the issue can only happen in a very narrow case, it would be better to take care of it.In this PR, a database migration is added for the case mentioned above, migrating the value of
log_statisticsfromtruetofalseagainst providers not supporting this feature. Also, a changelog entry is added as well to describe it.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]