Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(dns): style and typo fixes #13389

Merged
merged 4 commits into from
Jul 23, 2024
Merged

style(dns): style and typo fixes #13389

merged 4 commits into from
Jul 23, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jul 18, 2024 •
edited by chobits
Loading

Summary

Merge ready since #12305 was cherry-picked successfully.

KAG-5001

  • two blank lines between blocks
  • optimize table.insert
  • family should compare to domain, not name.

Checklist

Issue reference

Fix #[issue number]

@chronolaw chronolaw requested a review from chobits July 18, 2024 07:25
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jul 18, 2024
@chronolaw chronolaw mentioned this pull request Jul 18, 2024
Merged
3 tasks
@chobits chobits marked this pull request as draft July 22, 2024 08:28
@chobits
Copy link
Contributor

chobits commented Jul 22, 2024

I drafted this, cause we need to add more tests case, wait a moment while I add the test cases

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 23, 2024
@chobits chobits marked this pull request as ready for review July 23, 2024 03:55
chobits
chobits approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with more test cases for these two APIs

@windmgc windmgc merged commit 3a32637 into master Jul 23, 2024
37 checks passed
@windmgc windmgc deleted the style/typofix_for_dns_client branch July 23, 2024 06:56
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsinre outsinre outsinre approved these changes

@windmgc windmgc windmgc approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/docs size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @chobits @team-gateway-bot @windmgc @outsinre