-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry): support variable resource attributes #13839
base: master
Are you sure you want to change the base?
feat(opentelemetry): support variable resource attributes #13839
Conversation
failing test is expected, let's rebase after #13877 is merged |
6dc12b9
to
eaf8f25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution, this is great! I left a few comments for things that I feel could be improved a bit. There's some code duplication with request-transformer
that we may want to take care of, but that refactor can be done later.
eaf8f25
to
8a185af
Compare
0581567
to
4cfc804
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick action! I left a couple more suggestions, then I think it's good to go.
4cfc804
to
aba7105
Compare
aba7105
to
48c4be0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!!
Could you just update the documentation line for this configuration field in the plugin's schema? This is used to auto-generate docs.
f9e3afb
to
4e2c7ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job and thanks again!
Edit: sorry about the failing CI, it's because the new schema description exceeded the length limit, if you undo that change I'll take care of updating the plugin's docs as required.
4e2c7ab
to
d5a0c23
Compare
Summary
This change allows render resource attributes as lua code.
For example,
host.id
is0.0.0.0:9000
or depends onheaders.host
value.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #12538