feat(hmac) Implement request body validation #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the body digest sent in the Digest request header if the validate_request_body plugin config flag is set to true. Currently only SHA-256 digest is supported.
p0pr0ck5
force-pushed
the
feat/hmac-body-validate
branch
from
55e8f64 to
689ba02
Compare
p0pr0ck5
approved these changes
Jun 9, 2017
There was a problem hiding this comment.
Merging with some very minor changes. Thanks @shashiranjan84 and @vaibhavatul47!
bungle
added a commit
that referenced
this pull request
Nov 5, 2021
### Summary This is the final release of PCRE1. A few minor tidies are included. 1. CMakeLists.txt has two user-supplied patches applied, one to allow for the setting of MODULE_PATH, and the other to support the generation of pcre-config file and libpcre*.pc files. 2. There was a memory leak if a compile error occurred when there were more than 20 named groups (Bugzilla #2613). 3. Fixed some typos in code and documentation. 4. Fixed a small (*MARK) bug in the interpreter (Bugzilla #2771).
bungle
added a commit
that referenced
this pull request
Nov 5, 2021
### Summary This is the final release of PCRE1. A few minor tidies are included. 1. CMakeLists.txt has two user-supplied patches applied, one to allow for the setting of MODULE_PATH, and the other to support the generation of pcre-config file and libpcre*.pc files. 2. There was a memory leak if a compile error occurred when there were more than 20 named groups (Bugzilla #2613). 3. Fixed some typos in code and documentation. 4. Fixed a small (*MARK) bug in the interpreter (Bugzilla #2771).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional request body validation along with existing
headers validation. The motivation behind request body validation
is to detect body tampering. But as the validation process requires
to read the whole body in memory, which can affect Kong's
performance, this feature is disabled by default. User can change
the default behavior using config
validate-request-body.if config
validate-request-bodyis set totrue, validate requestbody along with headers validation. If it is
false, perform onlyheaders validation.
Full changelog
validate-request-bodyto schema.digestheader value.digestvalidation logic.Note: This PR is based of #2419 with some code refactoring.