fix(response-transformer) preserve empty arrays #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
approved these changes
Aug 13, 2019
When a response contains an empty array and it gets transformed, the empty array should remain an empty array (and not get transformed into an empty cjson object). Fixes #1208.
kikito
force-pushed
the
fix/response-transformer-empty-arrays
branch
from
8da3066
to
454f09c
Compare
hishamhm
pushed a commit
that referenced
this pull request
Aug 15, 2019
When a response contains an empty array and it gets transformed, the empty array should remain an empty array (and not get transformed into an empty cjson object). Fixes #1208.
fffonion
pushed a commit
that referenced
this pull request
Aug 31, 2022
#9186) …'t be properly re-encoded as an array. Instead, it becomes an empty json object. This PR fixes this issue. An empty json array will remain to be an empty json array after being decoded and re-encoded. This is a sister PR to PR: [#4901](#4901) It contains a similar fix, but now to `request-transformer` (this plugin). FTI-4205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a response contains an empty array and it gets transformed, the empty array should remain an empty array (and not get transformed into an empty cjson object).
Fixes #1208.