Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #769

Merged
merged 2 commits into from
Dec 4, 2015
Merged

Fix test #769

merged 2 commits into from
Dec 4, 2015

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Dec 4, 2015

Make tests more robust;

  • prevent tests from hanging when failing,
  • removed some ugly broken pipe errors,
  • added retry for a time sensitive test (getting pid from file not yet written)

Thijs Schreijer added 2 commits December 2, 2015 20:46
removed some ugly broken pipe errors,
added retry for a time sensitive test (getting pid from file not yet written)
@thibaultcha
Copy link
Member

I like this! tests need so much love! Thanks.

@subnetmarco
Copy link
Member

The CLI has been rewritten in feat/invalidations, so we need to make sure this is still relevant with the new code.

@thibaultcha
Copy link
Member

Well this touches the specs and

  • I don't think they have been changed in invalidations
  • If so, and if they are not relevant, then the person merging on rebasing invalidations is responsible for judging that and removing/adapting them as necessary.

thibaultcha added a commit that referenced this pull request Dec 4, 2015
@thibaultcha thibaultcha merged commit c38afeb into Kong:next Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants