Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pdk) update kong.log.inspect #7815

Merged
merged 1 commit into from
Sep 29, 2021
Merged

chore(pdk) update kong.log.inspect #7815

merged 1 commit into from
Sep 29, 2021

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Sep 7, 2021

inspect now works at debug level (was notice). This prevents nginx
from adding the trailing information and rendering the boxes
unreadable. Also the scope is now in the inspect output, in the
header, the top horizontal line.

Before:
Screenshot 2021-09-07 at 16 59 57

After:
Screenshot 2021-09-07 at 16 53 37

@Tieske Tieske requested a review from kikito September 7, 2021 15:37
@Tieske
Copy link
Member Author

Tieske commented Sep 7, 2021

fyi: best reviewed by hiding white-space changes

inspect now works at debug level (was notice). This prevents nginx
from adding the trailing information and rendering the boxes
unreadable. Also the scope is now in the inspect output, in the
header, the top horizontal line.
@kikito kikito merged commit 88de92e into master Sep 29, 2021
@bungle bungle deleted the inspect branch October 14, 2022 06:25
Tieske added a commit that referenced this pull request Sep 10, 2024
Reverts #7815

The inpect facility is used a lot for troubleshooting, but curently
requires debug level logs to be enabled, which will cause a lot of
noise. Also: the documentation still mentions inspect to log at notice level.

FTI-6215
bungle pushed a commit that referenced this pull request Sep 10, 2024
Reverts #7815

The inpect facility is used a lot for troubleshooting, but curently
requires debug level logs to be enabled, which will cause a lot of
noise. Also: the documentation still mentions inspect to log at notice level.

FTI-6215
curiositycasualty pushed a commit that referenced this pull request Oct 15, 2024
Reverts #7815

The inpect facility is used a lot for troubleshooting, but curently
requires debug level logs to be enabled, which will cause a lot of
noise. Also: the documentation still mentions inspect to log at notice level.

FTI-6215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants