fix(zipkin): jaeger header validation #8352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shettyh
force-pushed
the
jaeger_header_fix
branch
from
e6f9f34 to
0aad17f
Compare
shettyh
force-pushed
the
jaeger_header_fix
branch
from
0aad17f to
9a59fad
Compare
shettyh
force-pushed
the
jaeger_header_fix
branch
from
2a0a276 to
d38bc01
Compare
|
@shettyh can you fix the failing tests? Try to run |
|
@mayocream one of the integration test is failing, but i dont think it is related to this PR. Please check |
mayocream
approved these changes
Feb 9, 2022
|
Hello, I just approved this. Unfortunately it didn't make the cut for the 2.8 release, but should be included on the next one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the latest spec of
uber-trace-id, parent_id is not mandatory. Because of this zipkin plugin validation is failing if the parent_id is sent as0and it is recreating the header with newtrace_id. This results in not propagating the downstream context to upstream services.