-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(clustering) conditional rebuilding of router, plugins iterator and balancer on dp #8519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
perf/dp-hashes
branch
2 times, most recently
from
March 8, 2022 13:18
2ab1aaf
to
bc886bc
Compare
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (baseline,single_route,simple) Click to expand
|
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (baseline,single_route,simple) Click to expand
|
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (baseline,single_route,simple) Click to expand
|
fffonion
reviewed
Mar 15, 2022
fffonion
reviewed
Mar 15, 2022
fffonion
reviewed
Mar 15, 2022
fffonion
reviewed
Mar 15, 2022
fffonion
reviewed
Mar 15, 2022
…nd balancer on dp ### Summary Implements conditional rebuilding of `router`, `plugins iterator` and `balancer` on data planes. This means that DPs will not rebuild router if there were no changes in routes or services. Similarly, the plugins iterator will not be rebuild if there were no changes to plugins, and finally balancer in not reinitialized if there are no changes to upstreams or targets.
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (baseline,single_route,simple) Click to expand
|
fffonion
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🚀
aboudreault
pushed a commit
that referenced
this pull request
Apr 5, 2022
…nd balancer on dp (#8519) ### Summary Implements conditional rebuilding of `router`, `plugins iterator` and `balancer` on data planes. This means that DPs will not rebuild router if there were no changes in routes or services. Similarly, the plugins iterator will not be rebuild if there were no changes to plugins, and finally balancer in not reinitialized if there are no changes to upstreams or targets.
javierguerragiraldez
added a commit
that referenced
this pull request
Apr 12, 2022
bungle
added a commit
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements conditional rebuilding of
router
,plugins iterator
andbalancer
on data planes. This means that DPs will not rebuild router if there were no changes in routes or services. Similarly, the plugins iterator will not be rebuild if there were no changes to plugins, and finally balancer in not reinitialized if there are no changes to upstreams or targets.