fix(core) use admin_error_log for cluster listener #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `server {}` block previously had no `error_log` directive, so it
was inheriting the `proxy_error_log` settings from the `http {}` scope.
flrgh
force-pushed
the
fix/cluster-error-log
branch
from
f654478 to
d7e988c
Compare
|
@eskibars heads up/FYI. This is a fix for a bug/oversight, but it could be construed as a breaking change since we're effectively changing the default log file name for this area of the code. |
bungle
approved these changes
Mar 24, 2022
|
Threw in a late commit updating the integration test template to match |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
server {}block previously had noerror_logdirective, so it was inheriting theproxy_error_logsettings from thehttp {}scope. Logging to the same place asadmin_error_logis more sensible. We might want to consider introducing a newcluster_error_logconfig option at some point to give users more flexibility (usingadmin_error_logas a fallback), but to me this seems fine for now.