Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pdk): msgpack rpc functions handles binary #8623

Merged
merged 4 commits into from
Apr 6, 2022
Merged

fix(pdk): msgpack rpc functions handles binary #8623

merged 4 commits into from
Apr 6, 2022

Conversation

StarlightIbuki
Copy link
Contributor

fix #8622

@StarlightIbuki StarlightIbuki requested a review from ADD-SP April 1, 2022 08:35
@StarlightIbuki
Copy link
Contributor Author

this should also fix Kong/kong-python-pdk#50 and Kong/kong-js-pdk#156

ADD-SP
ADD-SP previously requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a relevant test so that the code can be made more robust.

@ADD-SP ADD-SP added the pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. label Apr 1, 2022
@StarlightIbuki StarlightIbuki requested a review from ADD-SP April 2, 2022 08:14
@bungle bungle dismissed ADD-SP’s stale review April 4, 2022 07:51

test was added.

@ADD-SP ADD-SP removed the pr/changes requested Changes were requested to this PR by a maintainer. Please address them and ping back once done. label Apr 6, 2022
@StarlightIbuki StarlightIbuki merged commit 2252818 into master Apr 6, 2022
@StarlightIbuki StarlightIbuki deleted the fix/mp_rpc_binary_retv branch April 6, 2022 07:23
StarlightIbuki added a commit to Kong/kong-js-pdk that referenced this pull request Apr 6, 2022
@StarlightIbuki
fix function signature for Kong/kong#8623
e68f87f
@fffonion fffonion mentioned this pull request Apr 6, 2022
Merged
StarlightIbuki added a commit to Kong/kong-js-pdk that referenced this pull request Apr 6, 2022
@StarlightIbuki
fix function signature for Kong/kong#8623 (#161)
2977f80
fffonion pushed a commit to Kong/kong-js-pdk that referenced this pull request Oct 7, 2022
@StarlightIbuki @fffonion
fix function signature for Kong/kong#8623 (#161)
3fc3702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierguerragiraldez javierguerragiraldez javierguerragiraldez approved these changes

@bungle bungle bungle approved these changes

@ADD-SP ADD-SP Awaiting requested review from ADD-SP

Assignees
No one assigned
Labels
core/docs core/language/go core/language/js core/language/python size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDK return string(not binary data) for get_raw_body for python and js
4 participants
@StarlightIbuki @javierguerragiraldez @bungle @ADD-SP