Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(balancer) do not reschedule resolve timer when reloading #8702

Merged
merged 2 commits into from
Apr 19, 2022
Merged

fix(balancer) do not reschedule resolve timer when reloading #8702

merged 2 commits into from
Apr 19, 2022

Conversation

locao
Copy link
Contributor

@locao locao commented Apr 19, 2022

Summary

Due to a missing check on DNS resolve timer callback, messages like this were logged when issuing a kong reload command:

2022/04/19 20:44:45 [crit] 80722#0: *17 [lua] targets.lua:248: could not reschedule DNS resolver timer: process exiting, context: ngx.timer

Full changelog

  • Added check for premature schedules and ignored those calls instead of trying to schedule and throwing an error.

@locao locao requested a review from a team as a code owner April 19, 2022 18:48
@locao locao requested a review from bungle April 19, 2022 18:49
@locao locao merged commit a05cc4c into master Apr 19, 2022
@locao locao deleted the fix/dns_resolve_timer_reload branch April 19, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

Assignees
No one assigned
Labels
changelog core/balancer size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@locao @bungle