Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "feat(dao) use cache_key for target uniqueness detec… #8768

Merged
merged 2 commits into from
May 16, 2022
Merged

Revert "Revert "feat(dao) use cache_key for target uniqueness detec… #8768

merged 2 commits into from
May 16, 2022

Conversation

dndx
Copy link
Member

@dndx dndx commented May 9, 2022

…tion" (#8705)"

This reverts commit 579537b.

hutchic
hutchic approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@hutchic hutchic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dndx dndx marked this pull request as ready for review May 11, 2022 10:21
@dndx dndx requested a review from a team as a code owner May 11, 2022 10:21
dndx added 2 commits May 16, 2022 02:22
@dndx
Revert "Revert "feat(dao) use cache_key for target uniqueness detec…
6a31b2d 
…tion" (#8705)"

This reverts commit 579537b.
@dndx
chore(rockspec) add missing rockspec entry for
eaea1dd 
`kong.db.migrations.core.016_280_to_300` which caused the packaging
failure before

Thanks @hutchic @flrgh for pointing out.
@dndx dndx merged commit 4759a29 into master May 16, 2022
@dndx dndx deleted the feat/cache_key_uniq branch May 16, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@hutchic hutchic hutchic approved these changes

Assignees
No one assigned
Labels
changelog core/admin-api core/db/migrations core/db size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dndx @hutchic @fffonion