fix(clustering) do not export plugins on a route attached to a disabled service #8816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
changed the title
bungle
reviewed
May 19, 2022
locao
reviewed
May 19, 2022
locao
requested changes
May 19, 2022
fffonion
reviewed
May 31, 2022
fffonion
approved these changes
May 31, 2022
ms2008
changed the title
fffonion
approved these changes
May 31, 2022
|
The new test failed, is it consistent failing or is it flaky? |
locao
previously requested changes
May 31, 2022
bungle
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix for a new DP get zero size config while service with plugin-enabled route is disabled.
The primary reason for this is CP does not totally filtering the exported config so when running in hybrid mode, DPs are sent disabled services and the routes/plugins associated with them.
FTI-4009 FTI-4040