chore(deps) bump openresty from 1.19.9.1 to 1.21.4.1 #8850
Conversation
bungle
force-pushed
the
chore/openresty-1.21.4.1
branch
2 times, most recently
from
0075a14
to
ffb96ea
Compare
bungle
force-pushed
the
chore/openresty-1.21.4.1
branch
2 times, most recently
from
b0b3dd0
to
4fb3c19
Compare
bungle
force-pushed
the
chore/openresty-1.21.4.1
branch
from
4fb3c19
to
75a88c0
Compare
### Summary Bump OpenResty from 1.19.9.1 to 1.21.4.1, see: https://openresty.org/en/changelog-1021004.html ### See Also Kong/kong-build-tools#473
bungle
force-pushed
the
chore/openresty-1.21.4.1
branch
from
75a88c0
to
5c78b9e
Compare
| @@ -20,6 +20,6 @@ return { | |||
| -- third-party dependencies' required version, as they would be specified | |||
| -- to lua-version's `set()` in the form {from, to} | |||
| _DEPENDENCIES = { | |||
| nginx = { "1.19.3.1", "1.19.9.1" }, | |||
| nginx = { "1.21.4.1" }, | |||
There was a problem hiding this comment.
not a blocker, but i'm curious on the reason behind this restriction, is there a specific behaviour we rely on that doesn't work with previous versions of openresty?
There was a problem hiding this comment.
@fffonion It is quite major change in Nginx, the behavior is very different, as seen in the changed tests. Also sooner rather than later we start to utilize things like string buffer with LuaJIT that is only available in latest.
There is nothing in particular that even lower versions couldn't be supported, it is just that nobody these days can just use plain OpenResty, you always need to include our patches etc. So why would anyone go even the hassle and build it with old OpenResty if they need to build it.
I see little benefit of supporting other versions.
Bump OpenResty from 1.19.9.1 to 1.21.4.1, see: https://openresty.org/en/changelog-1021004.html Kong/kong-build-tools#473
Summary
Bump OpenResty from 1.19.9.1 to 1.21.4.1, see:
https://openresty.org/en/changelog-1021004.html
See Also
This need to be reviewed and merged first, and proper releases of it needs to be tagged:
Kong/kong-build-tools#473