feat(vaults) remove beta label, migrate tables and enable bundled vaults #8871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/cli
core/db
core/db/migrations
core/pdk
core/templates
labels
### Summmary Kong `2.8.0` came with Vaults Beta, and that used `:8001/vaults-beta` Admin API endpoint and `kong.db.vaults_beta` DAO. This commit removes the beta labels from those. This commit also contains migrations to remove `_beta` label from underlying database tables.
### Summary On Kong `2.8.0` we released Vaults as `beta`. We also made it so that no Vaults were enabled by default. Now that we are getting to `3.0.0`, and we remove the `beta` label, the bundled Vaults should be enabled by default. This commit changes that.
bungle
force-pushed
the
feat/vaults-remove-beta-label
branch
from
dd8376a
to
5bef165
Compare
jschmid1
approved these changes
May 31, 2022
|
For EE and version compatibility, we might need to rename the entity to |
Good point. This is definitely hairy. |
hanshuebner
pushed a commit
that referenced
this pull request
Aug 25, 2022
hanshuebner
added a commit
that referenced
this pull request
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is quite awful, but it seems like there is no clear way to migrate over in single migration.
The migration has to do two things:
vaultstable tovault_auth_vaultsvaults_betatable tovaultstableOn Postgres it happens to do it in place on
upmigration. It is not blue-green, but it is impossible to make this blue-green in single migration without a lot of hacks in code itself. On Cassandra everything happens onfinishmigration as you don't have DDL like what Postgres offers. On Cassandra it is not blue-green either.Is this good enough?
vault_authplugin, which we think there are not that manyWe might want to add some migration tests (outside this PR).
The EE Vault auth plugin needs to be modified too (outside this PR).