fix(core) PDK crash when return array #8891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffonion
approved these changes
Jun 2, 2022
bungle
approved these changes
Jun 2, 2022
locao
pushed a commit
that referenced
this pull request
Apr 24, 2024
…8891) This makes a change to the shape/structure of dbless errors. Before this change, an upstream with duplicate targets would yield a response like this: ``` { "code": 14, "fields": { "targets": [ null, "uniqueness violation: 'targets' entity with primary key set to '48322e4a-b3b0-591b-8ed6-fd95a6d75019' already declared" ] }, "message": "declarative config is invalid: {targets={[2]=\"uniqueness violation: 'targets' entity with primary key set to '48322e4a-b3b0-591b-8ed6-fd95a6d75019' already declared\"}}", "name": "invalid declarative configuration" } ``` After this change, the errors are nested under the parent upstream: ``` { "code": 14, "fields": { "upstreams": [ null, { "targets": [ null, "uniqueness violation: 'targets' entity with primary key set to '48322e4a-b3b0-591b-8ed6-fd95a6d75019' already declared" ] } ] }, "message": "declarative config is invalid: {upstreams={[2]={targets={[2]=\"uniqueness violation: 'targets' entity with primary key set to '48322e4a-b3b0-591b-8ed6-fd95a6d75019' already declared\"}}}}", "name": "invalid declarative configuration" } ``` As a result, the error can now be properly mapped to the input target, so `POST /config?flatten_errors=1` returns a helpful result: ``` { "code": 14, "fields": {}, "flattened_errors": [ { "entity": { "id": "48322e4a-b3b0-591b-8ed6-fd95a6d75019", "tags": [ "target-2" ], "target": "10.244.0.12:80", "upstream": { "id": "f9792964-6797-482c-bfdf-08220a4f6839" }, "weight": 1 }, "entity_id": "48322e4a-b3b0-591b-8ed6-fd95a6d75019", "entity_tags": [ "target-2" ], "entity_type": "target", "errors": [ { "message": "uniqueness violation: 'targets' entity with primary key set to '48322e4a-b3b0-591b-8ed6-fd95a6d75019' already declared", "type": "entity" } ] } ], "message": "declarative config is invalid: {}", "name": "invalid declarative configuration" } ``` (cherry picked from commit b8891eb) Co-authored-by: Michael Martin <michael.martin@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong commit message.
fix #8734