chore(db) remove pre-workspace blue-green deployment workaround #8896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
chore/pre-workspace-workaround-removal
branch
from
e6233c8
to
7c127ef
Compare
|
Alternatively, we need to merge #8789. |
### Summary When Kong 2.1.0 was release we needed to add special workaround to enable blue-green deployment with the introduction of workspaces. We needed to add special `select_by_cache_key` to `Plugins` DAO. The check that we added is hurting the Kong performance, as seen reported in #8788. We got further PR from the author with #8789. While the fix is good, I do think we can remove this by now altogether. The only downside of this is that is people migrate directly from Kong < 2.1.x to `3.0.0` we don't support the blue-green deployment. ### Issues Resolved Fixes #8788 Closes #8789
bungle
force-pushed
the
chore/pre-workspace-workaround-removal
branch
from
7c127ef
to
2ca39e1
Compare
1 task
jschmid1
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Kong 2.1.0 was release we needed to add special workaround to enable blue-green deployment with the introduction of workspaces.
We needed to add special
select_by_cache_keytoPluginsDAO. The check that we added is hurting the Kong performance, as seen reported in #8788. We got further PR from the author with #8789. While the fix is good, I do think we can remove this by now altogether. The only downside of this, is that for people who migrate directly from Kong < 2.1.x to3.0.0, we don't support the blue-green deployment.Issues Resolved
Fixes #8788
Closes #8789