Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd)! remove support for declarative config in Lua format #8898

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

kikito
Copy link
Member

@kikito kikito commented Jun 3, 2022

For a while we accepted .lua declarative configurations via command-line only, but not on the admin API.

BREAKING CHANGE: Dropped support for loading declarative configuration in .lua format using the command-line tool

Summary

Full changelog

  • [Implement ...]
  • [Add related tests]
  • ...

Issue reference

Fix #[issue number]

Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft-approved, just gets tests clean before merging.

@kikito kikito force-pushed the conf/remove-declarative-lua branch from 247ad5a to 810bce5 Compare June 3, 2022 14:43
@kikito kikito force-pushed the conf/remove-declarative-lua branch from 810bce5 to 8478954 Compare June 21, 2022 15:04
kikito added 2 commits June 21, 2022 19:19
For a while we accepted .lua declarative configurations via command-line only, but not on the admin API.

BREAKING CHANGE: Dropped support for loading declarative configuration in .lua format using the command-line tool
@kikito kikito force-pushed the conf/remove-declarative-lua branch from 8478954 to ff340a2 Compare June 21, 2022 17:19
@kikito kikito merged commit b1af8d7 into master Jun 21, 2022
@kikito kikito deleted the conf/remove-declarative-lua branch June 21, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants