feat(rate-limting) allow to set error code and error message #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshuebner
approved these changes
Oct 21, 2022
hbagdi
changed the title
flrgh
reviewed
Oct 24, 2022
utix
force-pushed
the
plugins/rate-limiting/errorConfig
branch
from
8d12693
to
881317b
Compare
utix
force-pushed
the
plugins/rate-limiting/errorConfig
branch
from
881317b
to
9c25da5
Compare
|
I have added a dedicated test as asked, and rebase on master |
flrgh
approved these changes
Oct 25, 2022
|
@flrgh Good to hit the merge button? |
|
Should we add a change log for this? |
I think so, people are looking for this, at least one people asked for it on stackoverflow |
dndx
pushed a commit
that referenced
this pull request
Oct 28, 2022
|
This PR misses adding the field to removed_fields.lua. |
StarlightIbuki
added a commit
that referenced
this pull request
Oct 28, 2022
We should remove newly added config fields for older DP.
flrgh
added a commit
that referenced
this pull request
Oct 28, 2022
fffonion
pushed a commit
that referenced
this pull request
Nov 3, 2022
We should remove newly added config fields for older DP.
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…stom_id field description (#8930) * chore(docs): reword consumers username and custom_id field description (cherry picked from commit fd27e2e) * Update kong/db/schema/entities/consumers.lua Co-authored-by: Hisham Muhammad <hisham@gobolinux.org> (cherry picked from commit 92c185e) --------- Co-authored-by: Patryk Małek <patryk.malek@konghq.com> Co-authored-by: Patryk Małek <malekpatryk+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Error code and error message are hardcoded for rate-limiting plugin.
This allow to set them via configuration
Issue reference
https://stackoverflow.com/questions/72557894/how-can-i-replace-kong-error-to-a-custom-text