Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin) add the worker info to the response of /timers #8999

Merged
merged 3 commits into from
Jun 24, 2022
Merged

fix(admin) add the worker info to the response of /timers #8999

merged 3 commits into from
Jun 24, 2022

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Jun 23, 2022

Summary

  • style(runloop) use every timer instead of at timer to rebuild router and plugin iterator
  • feat(AdminAPI) add the worker info to the response of /timers
  • tests(helpers) extend function wait_timer

@ADD-SP ADD-SP requested a review from a team as a code owner June 23, 2022 08:15
@ADD-SP ADD-SP force-pushed the add_sp/unknown/rebuild-timers branch 3 times, most recently from 49d7bb8 to 3f2b274 Compare June 23, 2022 09:29
fffonion
fffonion reviewed Jun 23, 2022
View reviewed changes
kong/globalpatches.lua Outdated
@@ -101,6 +101,14 @@ return function(options)
return timerng:every(interval, callback, ...)
end

_G.named_timer_at = function (name, delay, callback, ...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking if we should properly move those functions that invokes timerng in a single table, like kong.timer.named_at.

@ADD-SP ADD-SP force-pushed the add_sp/unknown/rebuild-timers branch 8 times, most recently from 83d7ea5 to eb8038f Compare June 23, 2022 13:20
@ADD-SP ADD-SP force-pushed the add_sp/unknown/rebuild-timers branch from eb8038f to 7ab0ae1 Compare June 23, 2022 13:33
@ADD-SP ADD-SP force-pushed the add_sp/unknown/rebuild-timers branch from 7ab0ae1 to 54a01cf Compare June 24, 2022 10:07
@ADD-SP ADD-SP changed the title feat(AdminAPI) add the worker info to the response of /timers fix(admin) add the worker info to the response of /timers Jun 24, 2022
@fffonion fffonion merged commit 5707260 into master Jun 24, 2022
@fffonion fffonion deleted the add_sp/unknown/rebuild-timers branch June 24, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

Assignees
No one assigned
Labels
autodoc core/admin-api core/proxy size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADD-SP @fffonion