fix(core) stop percent decoding regex path #9024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Percent decoding of |
|
A tricky problem: We need a "back migration" to change the config back to 2.8 formats. It's safe to leave most of the characters not changed (and we can not tell if they are not from origin config but decoded in migration). The only character that may cause problems is "%", and it may be double |
StarlightIbuki
force-pushed
the
fix/stop-percent-decoding-regex-path
branch
from
18f26ff
to
0c57db4
Compare
StarlightIbuki
force-pushed
the
fix/stop-percent-decoding-regex-path
branch
from
0c57db4
to
9fb82ce
Compare
chronolaw
reviewed
Jun 29, 2022
StarlightIbuki
force-pushed
the
fix/stop-percent-decoding-regex-path
branch
from
e15a692
to
14084ec
Compare
|
I've tested migration in my local env and it works as expected. |
It's not a very reliable and sound way to support percent encoding in regex. We choose to tell users that we have a normalized (standard) form to match with so there's no ambiguity. fix CT-344
StarlightIbuki
force-pushed
the
fix/stop-percent-decoding-regex-path
branch
from
4bb71f0
to
e736b5c
Compare
fffonion
reviewed
Jul 4, 2022
fffonion
approved these changes
Jul 4, 2022
bungle
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a very reliable and sound way to support percent-encoding in regex. We choose to tell users that we have a normalized (standard) form to match with so there's no ambiguity.
#8140 (comment)
fix CT-344