fix(clustering) do not register events multiple times #9082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary This reduces double event handling and event publishing on clustering. On further PRs we can reduce double exporting, json decoding, calculate hashing etc. that are common between wrpc control plane and json control plane, but here I just fixed the double event handling.
StarlightIbuki
approved these changes
Jul 12, 2022
| @@ -22,6 +24,37 @@ local ngx_WARN = ngx.WARN | |||
| local _log_prefix = "[clustering] " | |||
|
|
|||
|
|
|||
| -- Sends "clustering", "push_config" to all workers in the same node, including self | |||
There was a problem hiding this comment.
Could we put those config sync related codes into a separate file?
There was a problem hiding this comment.
Will be done on following refactoring PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reduces double event handling and event publishing on clustering.
On further PRs we can reduce double exporting, json decoding, calculate hashing etc. that are common between wrpc control plane and json control plane, but here I just fixed the double event handling.