fix(plugins) gRPC gateway uri para bool handling #9180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC gateway should handle "false" argument as false for boolean parameters fix FTI-3335
|
For who wants to review: |
ADD-SP
reviewed
Aug 3, 2022
ADD-SP
approved these changes
Aug 3, 2022
StarlightIbuki
added a commit
that referenced
this pull request
Aug 9, 2022
gRPC gateway should handle the "false" argument as false for boolean parameters. This change is to be consistent with [grpc-gateway](https://github.com/grpc-ecosystem/grpc-gateway), where by `http://localhost:8090/v1/example/echo?stringv=false&boolean=false&number=1` you get: ```json { "stringv": "false", "boolean": false, "number": 1 } ``` as echo. Before this fix, any value passed to a boolean parameter is treated as a string and thus encoded as `true`. Fix FTI-3335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC gateway should handle the "false" argument as false for boolean parameters.
This change is to be consistent with grpc-gateway, where by
http://localhost:8090/v1/example/echo?stringv=false&boolean=false&number=1you get:{ "stringv": "false", "boolean": false, "number": 1 }as echo.
Before this fix, any value passed to a boolean parameter is treated as a string and thus encoded as
true.Fix FTI-3335