fix(dao) add recursion over entities that need to be cascade-deleted #9261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a scenario where `consumer` entities were deleted, the `oauth2_tokens` entities didn't have their caches invalidated. This is because the `find_cascade_delete_entities` function was only finding entities up to a maximum of two levels. So in this case where `consumer` is referenced by `oauth2_credentials` and `oauth2_credentials` is referenced by `oauth2_tokens` (consumer -> oauth2_credentials -> oauth2_tokens), only the `consumer` and `oauth2_credentials` had their cache invalidated, the `oauth2_tokens` caches had their cache still valid after a DELETE operation. The `find_cascade_delete_entities` function of the DAO module needs to be recursive because of this issue. So this PR is doing that, plus it's adding unit tests along with integration tests for the `oauth2` plugin. Fix FTI-2023
bungle
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a scenario where
consumerentities were deleted, theoauth2_tokensentities didn't have their caches invalidated. This isbecause the
find_cascade_delete_entitiesfunction was only findingentities up to a maximum of two levels. So in this case where
consumeris referenced byoauth2_credentialsandoauth2_credentialsis referenced byoauth2_tokens(consumer ->oauth2_credentials -> oauth2_tokens), only the
consumerandoauth2_credentialshad their cache invalidated, theoauth2_tokenscaches had their cache still valid after a /consumers DELETE operation. The
find_cascade_delete_entitiesfunction of the DAO module needs to berecursive because of this issue. So this PR is doing that, plus it's
adding unit tests along with integration tests for the
oauth2plugin.Fix FTI-2023