Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(router) rename atc to expression #9263

Merged
merged 8 commits into from
Aug 24, 2022
Merged

chore(router) rename atc to expression #9263

merged 8 commits into from
Aug 24, 2022

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Aug 18, 2022 •
edited
Loading

Summary

rename 'atc' to 'expression'

  • router_flavor rename to expressions
  • Route entity rename to expression as field name

@chronolaw chronolaw marked this pull request as ready for review August 20, 2022 08:07
@chronolaw chronolaw requested a review from a team as a code owner August 20, 2022 08:07
@mayocream mayocream added this to the 3.0 milestone Aug 23, 2022
@bungle
Copy link
Member

bungle commented Aug 23, 2022 •
edited by chronolaw
Loading

The ATC is still mentioned here:
https://github.com/Kong/kong/blob/master/.requirements#L11

@chronolaw
Copy link
Contributor Author

The ATC is still mentioned here: https://github.com/Kong/kong/blob/master/.requirements#L11

I think the normal user can not see this file, and we will not change atc-router's repo name now.

@chronolaw chronolaw mentioned this pull request Aug 23, 2022
Merged
@bungle
Copy link
Member

bungle commented Aug 23, 2022

What about:
https://github.com/Kong/kong/blob/master/kong/router/atc_compat.lua#L414

@chronolaw
Copy link
Contributor Author

What about: https://github.com/Kong/kong/blob/master/kong/router/atc_compat.lua#L414

Good catch. I will fix it.

dndx
dndx requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router_flavor should be expressions, Route entity should use expression as field name. The plural is important.

kong/conf_loader/init.lua Outdated Show resolved Hide resolved
@dndx dndx merged commit a0c3296 into master Aug 24, 2022
@dndx dndx deleted the chore/rename_atc branch August 24, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@mayocream mayocream mayocream approved these changes

Assignees
No one assigned
Labels
core/configuration core/db/migrations core/db schema-change-noteworthy size/S
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @bungle @dndx @mayocream