fix(balancer) stop DNS renewal on target event #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
approved these changes
Aug 18, 2022
locao
approved these changes
Aug 18, 2022
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
(cherry picked from commit #13061) Co-authored-by: Chrono <chrono_cpp@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
import from #8497
This bug fix pr was not merged to master, this PR can add this.
But the difference is this PR fixes two bug
on_target_event, So this get_upstream_by_id can return unexpectly.target_M.init()was called multiple times(in hybrid mode),renewal_heapandrenewal_weak_cachehave some Residual data, So we must delete this.Full changelog
"create"is received, remove the hostname from the heap containing the hostnames that must be resolved.targets.lua, no tests were added.Issue reference
Fix FTI-2927 FTI-4219