fix(handler) reverted logic to old one in var.upstream_uri concatenation logic #9269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshuebner
approved these changes
Aug 18, 2022
…ion logic ### Summary It was reported by @joshkping in #9246 that your handler may runtime crash in certain cases. This started to happen after this commit was merged: 44d24a2 It looks like this affects a lot of versions: - 2.8.1 - 2.8.0 - 2.7.2 - 2.7.1 - 2.7.0 - 2.6.1 - 2.6.0 ### Issues Resolved Fix #9246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was reported by @joshkping in #9246 that your handler may runtime crash in certain cases. This started to happen after this commit was merged: 44d24a2
It looks like this affects a lot of versions:
Issues Resolved
Fix #9246