Revert "fix(clustering) DP errors when CP exits" #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a51d298.
|
What is the motivation for the revert? Did it not improve the log noise? |
|
cc @suika-kong |
|
That PR is using the wrong way to close connections. We cannot create threads in |
StarlightIbuki
approved these changes
Aug 25, 2022
chronolaw
approved these changes
Aug 25, 2022
locao
added a commit
that referenced
this pull request
Jun 21, 2024
* chore(ci): bump Pongo version * remove changelog file, internal only, not user facing * switch to 2.11.1 release-branch * chore(deps): bump Pongo to 2.11.1 --------- Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a51d298.
For errors were thrown when CP exits.
We need to rework this later then.