-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conf): support base64 encoded *_cert and *_cert_key #9367
Merged
samugi
merged 2 commits into
feat/conf-certs-env-and-vaults
from
feat/conf-certs-env-and-vaults-base64
Sep 2, 2022
Merged
feat(conf): support base64 encoded *_cert and *_cert_key #9367
samugi
merged 2 commits into
feat/conf-certs-env-and-vaults
from
feat/conf-certs-env-and-vaults-base64
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
reviewed
Sep 1, 2022
samugi
force-pushed
the
feat/conf-certs-env-and-vaults-base64
branch
from
September 2, 2022 10:21
e8525ae
to
caf9b83
Compare
samugi
changed the title
feat(config): support base64 encoded *_cert and *_cert_key
feat(conf): support base64 encoded *_cert and *_cert_key
Sep 2, 2022
This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
samugi
force-pushed
the
feat/conf-certs-env-and-vaults-base64
branch
from
September 2, 2022 11:08
caf9b83
to
89b0eeb
Compare
bungle
approved these changes
Sep 2, 2022
bungle
pushed a commit
that referenced
this pull request
Sep 2, 2022
* support base64 encoded *_cert and *_cert_key * support base64url encoding This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
bungle
pushed a commit
that referenced
this pull request
Sep 13, 2022
* support base64 encoded *_cert and *_cert_key * support base64url encoding This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
bungle
pushed a commit
that referenced
this pull request
Oct 4, 2022
* support base64 encoded *_cert and *_cert_key * support base64url encoding This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
bungle
pushed a commit
that referenced
this pull request
Oct 4, 2022
* support base64 encoded *_cert and *_cert_key * support base64url encoding This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
* support base64 encoded *_cert and *_cert_key * support base64url encoding This adds a test case to ensure base64 encoded properties are corectly parsed and decoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for base64(and base64url)-encoded *_cert and *_cert_key properties.
(continuation FT-3322)