Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conf): support base64 encoded *_cert and *_cert_key #9367

Merged

Conversation

samugi
Copy link
Member

@samugi samugi commented Sep 1, 2022

Summary

Add support for base64(and base64url)-encoded *_cert and *_cert_key properties.

(continuation FT-3322)

@samugi samugi requested a review from a team as a code owner September 1, 2022 16:55
@samugi samugi marked this pull request as draft September 1, 2022 16:55
@samugi samugi force-pushed the feat/conf-certs-env-and-vaults-base64 branch from e8525ae to caf9b83 Compare September 2, 2022 10:21
@samugi samugi changed the title feat(config): support base64 encoded *_cert and *_cert_key feat(conf): support base64 encoded *_cert and *_cert_key Sep 2, 2022
This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
@samugi samugi force-pushed the feat/conf-certs-env-and-vaults-base64 branch from caf9b83 to 89b0eeb Compare September 2, 2022 11:08
@samugi samugi marked this pull request as ready for review September 2, 2022 12:17
@samugi samugi merged this pull request into feat/conf-certs-env-and-vaults Sep 2, 2022
@samugi samugi deleted the feat/conf-certs-env-and-vaults-base64 branch September 2, 2022 13:16
bungle pushed a commit that referenced this pull request Sep 2, 2022
* support base64 encoded *_cert and *_cert_key
* support base64url encoding

This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
bungle pushed a commit that referenced this pull request Sep 13, 2022
* support base64 encoded *_cert and *_cert_key
* support base64url encoding

This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
bungle pushed a commit that referenced this pull request Oct 4, 2022
* support base64 encoded *_cert and *_cert_key
* support base64url encoding

This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
bungle pushed a commit that referenced this pull request Oct 4, 2022
* support base64 encoded *_cert and *_cert_key
* support base64url encoding

This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
oowl pushed a commit to oowl/kong that referenced this pull request Oct 12, 2022
* support base64 encoded *_cert and *_cert_key
* support base64url encoding

This adds a test case to ensure base64 encoded properties are corectly
parsed and decoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants