chore(error_handlers): define response message for trace method 405 error status code #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liverpool8056 Could you add a test case for this PR? |
liverpool8056
force-pushed
the
chore/FTI-4325-response-from-trace-method
branch
from
76d2d7a to
b5a049f
Compare
liverpool8056
force-pushed
the
chore/FTI-4325-response-from-trace-method
branch
from
b5a049f to
df21f63
Compare
|
|
liverpool8056
force-pushed
the
chore/FTI-4325-response-from-trace-method
branch
from
df21f63 to
103cbf7
Compare
|
@dndx So sorrrrrrry for missing test case, and thank you for helping me to correct it, I added the test case in the new commit. |
chronolaw
approved these changes
Oct 10, 2022
|
Should we add an entry in changelog? |
|
Due to PR #9513, we should rebase the PR and change the index from string to number. |
liverpool8056
force-pushed
the
chore/FTI-4325-response-from-trace-method
branch
from
103cbf7 to
ae3d56c
Compare
liverpool8056
force-pushed
the
chore/FTI-4325-response-from-trace-method
branch
from
ae3d56c to
f26785f
Compare
|
@chronolaw already done |
chronolaw
approved these changes
Oct 27, 2022
|
pinging @fffonion for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When nginx blocks request with trace method from client, it hits the default error message in kong which is "The upstream server responded with 405", it is a little ambiguous. Actually the request doesn't reach upstream.
Define a detail message "Method not allowed" for 405 status code.