-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentelemetry): set default propagation type to w3c #9457
Conversation
discussed with @mayocream and moving this out of 3.0.1 scope |
According to the original design, the default propagation header type should be `w3c`, described in https://docs.konghq.com/hub/kong-inc/opentelemetry/#propagation. > The plugin detects the propagation format from the headers and will use the appropriate format to propagate the span context. If no appropriate format is found, the plugin will failback to the default format, which is w3c. The previous implementation didn't specify the default header type successfully, it was failbacked to the `b3` default. WIP: add tests.
45ccac0
to
e2b2020
Compare
i am using kong 3.4.2 and still i am getting @mayocream cloud you help me to resolve this ?? |
hi @dhanutalari, are the requests that generated those logs passing any If that is the case, in This obviously did not offer a lot of flexibility, the propagation module has recently been rewritten to enable better configurability and complete freedom in deciding how headers propagation behaves (i.e. how Kong extracts/injects tracing headers). The new propagation module is unreleased at the moment but will soon be available in |
According to the original design, the default propagation header type should be
w3c
, described in https://docs.konghq.com/hub/kong-inc/opentelemetry/#propagation.The previous implementation didn't specify the default header type successfully, it was failback to the
b3
default.