fix(admin): fix potentially truncate arguments #9510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. increase max_uri_args and max_post_args to 1000 2. return 400 while reach the maximum argument number
chronolaw
reviewed
Oct 9, 2022
chronolaw
reviewed
Oct 9, 2022
spec/02-integration/04-admin_api/21-truncated_arguments_spec.lua
Outdated
Show resolved
Hide resolved
mayocream
reviewed
Oct 9, 2022
chronolaw
reviewed
Oct 10, 2022
spec/02-integration/04-admin_api/21-truncated_arguments_spec.lua
Outdated
Show resolved
Hide resolved
chronolaw
reviewed
Oct 10, 2022
spec/02-integration/04-admin_api/21-truncated_arguments_spec.lua
Outdated
Show resolved
Hide resolved
fffonion
approved these changes
Oct 11, 2022
|
Should we add an entry in changelog? |
|
Yes, right thanks for reminding @chronolaw ! |
vm-001
added a commit
that referenced
this pull request
Oct 11, 2022
vm-001
added a commit
that referenced
this pull request
Oct 11, 2022
vm-001
added a commit
that referenced
this pull request
Oct 11, 2022
Admin API will quietly truncate the request post arguments if reach the limit(100), which might cause data inconsistency issues. FTI-4417
fffonion
pushed a commit
that referenced
this pull request
Oct 12, 2022
oowl
pushed a commit
to oowl/kong
that referenced
this pull request
Oct 12, 2022
Admin API will quietly truncate the request post arguments if reach the limit(100), which might cause data inconsistency issues. FTI-4417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Admin API will quietly truncate the request post arguments if reach the limit(100), which might cause data inconsistency issues.
Full changelog
Issue reference
FTI-4407