Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdk): add request.get_uri_captures #9512

Merged
merged 17 commits into from
Oct 18, 2022
Merged

feat(pdk): add request.get_uri_captures #9512

merged 17 commits into from
Oct 18, 2022

Conversation

StarlightIbuki
Copy link
Contributor

fix FTI-3994

@StarlightIbuki StarlightIbuki requested a review from a team as a code owner October 9, 2022 09:05
This was referenced Oct 9, 2022
Closed
Merged
chronolaw
chronolaw reviewed Oct 10, 2022
View reviewed changes
kong/runloop/plugin_servers/init.lua Outdated Show resolved Hide resolved
kong/runloop/plugin_servers/init.lua Outdated Show resolved Hide resolved
kong/runloop/plugin_servers/init.lua Outdated Show resolved Hide resolved
kong/runloop/plugin_servers/init.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw changed the title feat(pdk) add request.get_uri_captures feat(pdk): add request.get_uri_captures Oct 10, 2022
@chronolaw
Copy link
Contributor

Could we add some test cases for this new pdk api?

@StarlightIbuki StarlightIbuki marked this pull request as draft October 10, 2022 08:19
@StarlightIbuki StarlightIbuki mentioned this pull request Oct 11, 2022
Merged
@StarlightIbuki StarlightIbuki marked this pull request as ready for review October 11, 2022 06:10
fffonion
fffonion reviewed Oct 11, 2022
View reviewed changes
kong/pdk/request.lua Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 11, 2022
@StarlightIbuki StarlightIbuki force-pushed the feat/pdk/get_uri_captures branch 2 times, most recently from 438b31e to 8bc4adb Compare October 12, 2022 09:18
chronolaw
chronolaw reviewed Oct 13, 2022
View reviewed changes
kong/pdk/request.lua Outdated Show resolved Hide resolved
fffonion
fffonion approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge after rebase

chronolaw
chronolaw reviewed Oct 18, 2022
View reviewed changes
kong/pdk/request.lua Outdated Show resolved Hide resolved
@fffonion fffonion merged commit 4e59190 into Kong:master Oct 18, 2022
@chronolaw chronolaw mentioned this pull request Oct 18, 2022
Merged
@StarlightIbuki StarlightIbuki deleted the feat/pdk/get_uri_captures branch October 21, 2022 03:44
@fffonion fffonion mentioned this pull request Jun 15, 2023
Open
locao pushed a commit that referenced this pull request Jun 21, 2024
@team-gateway-bot @StarlightIbuki
@gszr @ADD-SP
fix(core): do not accept invalid regex pattern when validating the `r…
61bf74c 
…oute` entity (#9512)

Fix FTI-5403

Cherry-picked from #12365

---------

Co-authored-by: Xumin <100666470+StarlightIbuki@users.noreply.github.com>
Co-authored-by: Guilherme Salazar <gsz@acm.org>
Co-authored-by: Qi <add_sp@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@chronolaw chronolaw Awaiting requested review from chronolaw

Assignees
No one assigned
Labels
changelog core/language/go core/language/js core/language/python core/pdk size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarlightIbuki @chronolaw @fffonion