Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opentelemetry): fix parent_id reporting from w3c header #9628

Merged
merged 3 commits into from
Nov 3, 2022
Merged

fix(opentelemetry): fix parent_id reporting from w3c header #9628

merged 3 commits into from
Nov 3, 2022

Conversation

MartinBurian
Copy link
Contributor

Summary

When trace context is propagated in w3c format header, the parent_id is not set on the root span and not reported to the collector. I could not come up with a way to cover it in the tests.

Full changelog

  • Fix parent_id reporting in traces propagating through w3c headers

Issue reference

Fix #9627

@MartinBurian MartinBurian requested a review from a team as a code owner October 27, 2022 08:16
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hbagdi hbagdi requested a review from mayocream October 27, 2022 18:18
mayocream
mayocream reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@mayocream mayocream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll add a coordinated test.

kong/plugins/opentelemetry/handler.lua Show resolved Hide resolved
@StarlightIbuki StarlightIbuki force-pushed the fix/tracing-w3c-propagation branch from a878c5a to 118c704 Compare October 31, 2022 07:07
@mayocream mayocream force-pushed the fix/tracing-w3c-propagation branch from e42063e to 97a3a78 Compare November 2, 2022 08:19
@hbagdi hbagdi requested a review from flrgh November 2, 2022 17:14
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Nov 3, 2022
@mayocream mayocream force-pushed the fix/tracing-w3c-propagation branch from 9ea3990 to b0db488 Compare November 3, 2022 04:44
MartinBurian and others added 2 commits November 3, 2022 12:49
@MartinBurian @mayocream
fix(opentelemetry): fix parent_id reporting from w3c header
cbe03f5 
When trace context is propagated in w3c format header, the parent_id is
not set on the root span and not reported to the collector.

Fixes Kong#9627
@mayocream
tests(otel): propagate w3c traceparent
fcc5ecb
@mayocream mayocream force-pushed the fix/tracing-w3c-propagation branch from b0db488 to fcc5ecb Compare November 3, 2022 04:49
@mayocream mayocream linked an issue Nov 3, 2022 that may be closed by this pull request
OpenTelemetry invalid parent span IDs=XXX; skipping clock skew adjustment #9458
Closed
1 task
@fffonion fffonion merged commit ec03f08 into Kong:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayocream mayocream mayocream approved these changes

@flrgh flrgh Awaiting requested review from flrgh

Assignees

@flrgh flrgh

@mayocream mayocream

Labels
changelog plugins/opentelemetry size/M
Projects
None yet
Milestone
No milestone
5 participants
@MartinBurian @CLAassistant @mayocream @fffonion @flrgh