-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http-log): support http_endpoint field to be referenceable #9714
Conversation
I've not seen any vault test case for the individual plugin that uses referenceable field. So I assume that instead of adding the test case for that, Kong prefers using a single test case for vault feature(https://github.com/Kong/kong/blob/master/spec/02-integration/13-vaults/02-env_vault_spec.lua. (Correct me if I'm wrong). Thus, this PR didn't contain test case for that. |
Discussed with @vm-001 offline, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would need to be accompanied by one test
Removing from the 3.1 milestone per this comment. If something changes go ahead and add it back in. |
74b07dd
to
ae174df
Compare
Test added. Please let me know if anything else required. |
I remember there were discussions that question if it makes sense to make this reference able (and general concern over making too many non-secret configs referenceable). @vm-001 do you remember the decision on this one? |
As per discussion in the planning meeting, we're not going to globally make everything referencable. We're thus going to merge this once tests pass. |
Summary
Support
http_endpoint
field to be referenceableFull changelog
http_endpoint
field to be referenceableIssue reference
Internal ticket FTI-4483