Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(balancer): add latency balancer algorithm #9787

Merged
merged 26 commits into from
Jan 25, 2023
Merged

feat(balancer): add latency balancer algorithm #9787

merged 26 commits into from
Jan 25, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Nov 20, 2022 •
edited
Loading

Summary

add latency balancer algorithm

FTI-4099
KAG-79

Checklist

Full changelog

  1. change the balancer system function code to support updating the balancer status in the log phase
  2. introduce the latency balancer algorithm

https://linkerd.io/2016/03/16/beyond-round-robin-load-balancing-for-latency/

@chronolaw chronolaw marked this pull request as draft November 21, 2022 06:33
@chronolaw chronolaw added the pr/wip A work in progress PR opened to receive feedback label Nov 21, 2022
@oowl oowl force-pushed the feat/ewma-banlancer branch from b38306a to 39e44f8 Compare November 22, 2022 10:13
@oowl oowl force-pushed the feat/ewma-banlancer branch 7 times, most recently from cc893f0 to a854491 Compare November 23, 2022 15:20
@oowl oowl force-pushed the feat/ewma-banlancer branch from a854491 to 42a058b Compare December 13, 2022 07:34
@oowl oowl removed the pr/wip A work in progress PR opened to receive feedback label Dec 13, 2022
@oowl oowl marked this pull request as ready for review December 13, 2022 07:36
@oowl oowl force-pushed the feat/ewma-banlancer branch from 42a058b to e896095 Compare December 19, 2022 03:22
@chronolaw
Copy link
Contributor

Needs a change log entry.

oowl and others added 22 commits January 21, 2023 01:27
@oowl
fix(balancer): add rockspec
e11de80
@oowl
fix(balancer): fix db entities overwrite function
13560d5
@oowl
tests(balancer): make ewma balancer spec happy
fefd7f7
@oowl
tests(balancer): fix ewma unit test spec
b1c3d8e
@oowl
tests(balancer): fix ewma integration test
76b78fc
@oowl
tests(balancer): add ewma integration test case
8870cd8
@oowl
fix(balancer): cleanup ewma code
7c151d3
@oowl
tests(balancer): make ewma integration test happy
f8865de
@oowl
fix(balancer): fix ewma code style
4c222da
@oowl
fix(balancer): fix ewma code style
f74e5fd
@oowl
fix(balancer): fix ewma code style
cecfc81
@oowl @locao
Update spec/01-unit/09-balancer/06-ewma_spec.lua
0d904ee 
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
@oowl @locao
Update spec/01-unit/09-balancer/06-ewma_spec.lua
c930b5c 
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
@oowl
fix: fix test
c448f93
@oowl
fix test
f2de8ef
@oowl
fix code
3b08dff
@oowl
fix test
46cac10
@oowl
fix test
444e5bb
@oowl
fix test
15a6621
@oowl
feat(balancer): rename ewma to latency
3779bec
@oowl
feat(balancer): rename ewma to latency
7a67d7f
@oowl
feat(balancer): fix log message
802e333
@oowl oowl force-pushed the feat/ewma-banlancer branch from 6dc1823 to 802e333 Compare January 20, 2023 17:27
@locao locao changed the title feat(balancer): add latency banlancer algorithm feat(balancer): add latency balancer algorithm Jan 20, 2023
@locao locao merged commit 0d75a8e into Kong:master Jan 25, 2023
chronolaw added a commit that referenced this pull request Jan 30, 2023
@chronolaw
add changelog for #9787
f52ada0
@chronolaw chronolaw mentioned this pull request Jan 30, 2023
Merged
@oowl oowl mentioned this pull request Jan 30, 2023
Merged
dndx added a commit that referenced this pull request Jan 30, 2023
@chronolaw @dndx
docs(changelog): add changelog entry for #9787 (the latency based loa…
ff6e8d8 
…d balancing algorithm)

Co-authored-by: Datong Sun <datong.sun@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

@colinh-kong colinh-kong colinh-kong left review comments

@locao locao locao approved these changes

@Tieske Tieske Awaiting requested review from Tieske

@hbagdi hbagdi Awaiting requested review from hbagdi

@dndx dndx Awaiting requested review from dndx

@bungle bungle Awaiting requested review from bungle

Assignees
No one assigned
Labels
core/balancer core/db core/proxy schema-change-noteworthy size/XXL
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@oowl @chronolaw @colinh-kong @locao