feat(zipkin): add support for labeling phase duration as tags #9891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayocream
force-pushed
the
feat/zipkin-tags-duration
branch
from
5c8aea2 to
98b4923
Compare
mayocream
force-pushed
the
feat/zipkin-tags-duration
branch
from
a54dc1e to
7d7d620
Compare
Co-authored-by: Qirui(Keery) Nie <windmgc@gmail.com>
|
@mayocream Can you please add a changelog entry and open a corresponding documentation PR? |
Ahh, I already added the changelog entry; I just forgot to update the PR checklist. |
flrgh
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to set durations as span tags.
Checklist
Issue reference
Fix #8126
Reimplement #8264
FTI-4507